This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653 )
Change subject: Simplify raid data storage
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653/2/include/osmocom/sgsn/gb_proxy.h
File include/osmocom/sgsn/gb_proxy.h:
https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653/2/include/osmocom/sgsn/gb_proxy.h@115
PS2, Line 115: struct {
There's already struct osmo_cgi_ps in case you want to reuse it. However I see it may be more handy using this self struct since you memcpy it from somewhere else.
https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653/2/src/gb_proxy_ctrl.c
File src/gb_proxy_ctrl.c:
https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653/2/src/gb_proxy_ctrl.c@96
PS2, Line 96: cmd->reply = talloc_asprintf_append(cmd->reply, "%u,%u,%u,%u,%u,%u,%s\n",
Not related to this patch, but it would be better using the "%u-%u-%u" notation (as per specs) for RAI here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/22653
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: Ib58b9188e3ce4bd3fdadb03f158d56b29778387c
Gerrit-Change-Number: 22653
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Feb 2021 15:16:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210203/2b47d344/attachment.htm>