Change in libosmocore[master]: gprs_ns2: rework logging of Rx and Tx NS PDU

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Wed Feb 3 14:05:15 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22294 )

Change subject: gprs_ns2: rework logging of Rx and Tx NS PDU
......................................................................


Patch Set 14:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/22294/14/src/gb/gprs_ns2.c 
File src/gb/gprs_ns2.c:

https://gerrit.osmocom.org/c/libosmocore/+/22294/14/src/gb/gprs_ns2.c@1091 
PS14, Line 1091: 	LOG_NS_RX_SIGNAL(nsvc, nsh->pdu_type);
This also logs NS_PDUT_UNITDATA


https://gerrit.osmocom.org/c/libosmocore/+/22294/11/src/gb/gprs_ns2_internal.h 
File src/gb/gprs_ns2_internal.h:

https://gerrit.osmocom.org/c/libosmocore/+/22294/11/src/gb/gprs_ns2_internal.h@33 
PS11, Line 33: #define LOG_NS_TX_MESSAGE(nsvc, pdu_type) LOG_NS_MESSAGE(nsvc, "Tx", pdu_type, LOGL_INFO, "\n")
> Separate subsystems would be good, yeah.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22294
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I34b8fde2955ecc010d1dcd9512e1bba9211e2c0d
Gerrit-Change-Number: 22294
Gerrit-PatchSet: 14
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Feb 2021 14:05:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210203/53594d83/attachment.htm>


More information about the gerrit-log mailing list