This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22638 )
Change subject: ns2: improve backlog handling on interface up/down
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/c/libosmocore/+/22638/1/src/gb/gprs_ns2_fr.c
File src/gb/gprs_ns2_fr.c:
https://gerrit.osmocom.org/c/libosmocore/+/22638/1/src/gb/gprs_ns2_fr.c@589
PS1, Line 589: bpriv->if_running = if_running;
Since you are moving use of this field here, it probably makes sense to move the "if (bpriv->if_running != if_running) {" in function below at the start of this function.
if (bpriv->if_running == if_running)
continue;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22638
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib35d099526544fe2cff64566fd56147a906adab9
Gerrit-Change-Number: 22638
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Feb 2021 10:19:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210203/ce1faa46/attachment.htm>