Change in osmo-bts[master]: pcu_sock: send SI1, SI3 and SI13 via PCUIF

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Feb 2 21:21:04 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22541 )

Change subject: pcu_sock: send SI1, SI3 and SI13 via PCUIF
......................................................................


Patch Set 4:

(4 comments)

Also here, the PCUIF version does not need to get bumped.

https://gerrit.osmocom.org/c/osmo-bts/+/22541/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/22541/1//COMMIT_MSG@7 
PS1, Line 7: pcu_sock: send SI1, SI3 and SI3 via PCUIF
> SI13, not SI3 twice
Done


https://gerrit.osmocom.org/c/osmo-bts/+/22541/1/src/common/pcu_sock.c 
File src/common/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bts/+/22541/1/src/common/pcu_sock.c@752 
PS1, Line 752: 	int rc =
> This indentation looks rather weird, better inline int rc = pcu-tx_data_ind(... […]
Done


https://gerrit.osmocom.org/c/osmo-bts/+/22541/1/src/common/rsl.c 
File src/common/rsl.c:

https://gerrit.osmocom.org/c/osmo-bts/+/22541/1/src/common/rsl.c@397 
PS1, Line 397: 		if (SYSINFO_TYPE_13 == osmo_si)
> switch (osmo_si) […]
Done


https://gerrit.osmocom.org/c/osmo-bts/+/22541/1/src/common/rsl.c@417 
PS1, Line 417: 		if (SYSINFO_TYPE_13 == osmo_si)
> switch (osmo_si)
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22541
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib7aeb41e634ad6fcab3766a4667b0267c749436a
Gerrit-Change-Number: 22541
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Feb 2021 21:21:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210202/492929ba/attachment.htm>


More information about the gerrit-log mailing list