Change in osmo-sip-connector[master]: mncc: Fix write len

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Feb 2 16:33:48 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/22635 )

Change subject: mncc: Fix write len
......................................................................

mncc: Fix write len

Fixes bug introduced recently.

Closes: OS#4957
Fixes: 0f27b1bd397f5b54fdfabf447d6fca7f30ac2580
Change-Id: Ibbff004e2b76fbfe8962d14628c916afb19f30e6
---
M src/mncc.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/mncc.c b/src/mncc.c
index 6d42fde..9d75950 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -160,7 +160,7 @@
 {
 	int rc;
 
-	rc = write(conn->fd.fd, &rtp, sizeof(rtp));
+	rc = write(conn->fd.fd, rtp, sizeof(*rtp));
 	LOGP(DMNCC, LOGL_DEBUG, "MNCC sent message type: %s\n", osmo_mncc_name(rtp->msg_type));
 	if (rc != sizeof(*rtp)) {
 		LOGP(DMNCC, LOGL_ERROR, "Failed to send message for call(%u): %d\n", rtp->callref, rc);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/22635
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ibbff004e2b76fbfe8962d14628c916afb19f30e6
Gerrit-Change-Number: 22635
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210202/5df72758/attachment.htm>


More information about the gerrit-log mailing list