Change in osmo-gsm-manuals[master]: TRXC: add proposal for multiple Training Sequences

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Feb 2 15:49:25 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22611 )

Change subject: TRXC: add proposal for multiple Training Sequences
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22611/1/common/chapters/trx_if.adoc 
File common/chapters/trx_if.adoc:

https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22611/1/common/chapters/trx_if.adoc@198 
PS1, Line 198: ----
> Ack
Well, we're dealing with a *human readable* protocol here. I would love to go for something more convenient, so we would not need to mess with sprintf() / sscanf(), but re-designing the TRXC is out of scope so far. I just wanted this command to look a bit more readable.

With timeslot and subslot it's logical that the former goes first, from the hierarchical point of view. With the training sequence and set we could assume that set goes first, but the more parameters we add, the harder it gets to grasp what corresponds to what without looking at the protocol reference.

Regarding parsing complexity, it's just a longer format string for sscanf(), nothing special. If you both insist, I would change to plain numbers.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22611
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I621e46edac5d748472fd645f81876116904e260c
Gerrit-Change-Number: 22611
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Feb 2021 15:49:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210202/5041e719/attachment.htm>


More information about the gerrit-log mailing list