Change in osmo-pcu[master]: gprs_bssgp_rim: add serving BSS NACC application

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22368 )

Change subject: gprs_bssgp_rim: add serving BSS NACC application
......................................................................


Patch Set 9:

(5 comments)

The protocol version is increased because the PCUIF protocol changes at the point where we transmit the SI13 message.

We currently use the SAPI4 only for updating or revoking the SI13. The revoking of the SI13 works by sending an empty message. To extend this to a protocol where we are able to update or revoke SI1, SI3 or SI13 at the same time we need some extension. I did it the following way:

As there is an osmo_si type enum I used that as a header byte. Then the normal SI13 or SI1 or SI3 message follows. The revoking works by just sending the header byte only.

I wonder what we could do to get around bumping the PCUIF version. I think the only way would be to omit the header byte for SI13. Sending nothing would mean that only SI13 is revoked. Sending a pure SI13 with GSM_MACBLOCK_KEN would mean that SI13 is updated. All GSM_MACKBLOCK_LEN+1 messages would work by the new protocol. I find that this would be too ugly.

https://gerrit.osmocom.org/c/osmo-pcu/+/22368/6/src/gprs_bssgp_rim.c 
File src/gprs_bssgp_rim.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22368/6/src/gprs_bssgp_rim.c@69 
PS6, Line 69: 		app_cont->si[app_cont->num_si] = bts->si1 + 2;
> Add comment explaining what's this +2 about.
Done


https://gerrit.osmocom.org/c/osmo-pcu/+/22368/6/src/gprs_bssgp_rim.c@266 
PS6, Line 266: 		format_response_pdu(&resp_pdu, pdu, bts);
> You are passing here the "dst BTS" and you are then using then using it to gather the information to […]
Done


https://gerrit.osmocom.org/c/osmo-pcu/+/22368/7/src/gprs_bssgp_rim.c 
File src/gprs_bssgp_rim.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22368/7/src/gprs_bssgp_rim.c@271 
PS7, Line 271: 		if (rc != 0) {
> I think you mixed here the log message with the answer... […]
Done


https://gerrit.osmocom.org/c/osmo-pcu/+/22368/8/src/gprs_bssgp_rim.c 
File src/gprs_bssgp_rim.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22368/8/src/gprs_bssgp_rim.c@275 
PS8, Line 275: 			LOGPRIM(nsei, LOGL_NOTICE, "Responding to RAN INFORMATION REQUEST ...\n");
> NOTICE is too much here, should be INFO.
Done


https://gerrit.osmocom.org/c/osmo-pcu/+/22368/6/src/pcu_l1_if.cpp 
File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/22368/6/src/pcu_l1_if.cpp@300 
PS6, Line 300: 	if (len == 1) {
> switch (len) on all the possibilities in this function.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22368
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id72118120c14984d2fb1b918b41fac4868150d41
Gerrit-Change-Number: 22368
Gerrit-PatchSet: 9
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Feb 2021 15:04:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210202/dfd5618e/attachment.htm>