Change in osmo-pcu[master]: gprs_bssgp_rim: add serving BSS NACC application

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22368 )

Change subject: gprs_bssgp_rim: add serving BSS NACC application
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/22368/7/src/gprs_bssgp_rim.c 
File src/gprs_bssgp_rim.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22368/7/src/gprs_bssgp_rim.c@271 
PS7, Line 271: 		if (rc != 0) {
I think you mixed here the log message with the answer...
see when you call the pdu_err() and the pdu() functions, and how are they related to the the logging messages...

Also, I'd favour moving this to a new function being called below, like I did for BSSGP_IE_RI_RIM_CONTAINER, to better split the different layers, otherwise it becomes a bit confusing.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22368
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id72118120c14984d2fb1b918b41fac4868150d41
Gerrit-Change-Number: 22368
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Feb 2021 15:44:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210201/3d7206c8/attachment.htm>