This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22553 ) Change subject: osmo-ns-dummy: Add simple NS traffic generator ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/22553/2/utils/osmo-ns-dummy-vty.c File utils/osmo-ns-dummy-vty.c: https://gerrit.osmocom.org/c/libosmocore/+/22553/2/utils/osmo-ns-dummy-vty.c@189 PS2, Line 189: if (ntg->running) { > I would have used osmo_timer_pending() instead of running will try to get this merged first and then submit a patch to get rid of 'running' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iad3b694c85962dbbc6b4a27a0ed5bc841add464f Gerrit-Change-Number: 22553 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Comment-Date: Mon, 01 Feb 2021 08:30:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210201/519da645/attachment.htm>