Change in osmo-bsc[master]: fix gscon clear 2/n: proper state transition to ST_CLEARING

[neels]

Hello Jenkins Builder, ipse, pespin, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-bsc/+/26613

to look at the new patch set (#2).

Change subject: fix gscon clear 2/n: proper state transition to ST_CLEARING
......................................................................

fix gscon clear 2/n: proper state transition to ST_CLEARING

The way the ST_CLEARING is entered before this patch has various
symptoms of how I / we used osmo_fsm when we were still FSM amateurs in
Osmocom. Patch that up:

- In gscon_bssmap_clear(), ask for a state transition to ST_CLEARING
  first. Go ahead only if it is allowed.

- move the Clear Request messaging to ST_CLEARING's onenter function.

- Fix the timeout behavior: by using conn_fsm_state_chg(), use the
  actual proper X4 timer value for ST_CLEARING from VTY configuration
  instead of hardcoded magic numbers.

Related: OS#5337
Change-Id: I234b2a754d0c98031056981823cdbc187e977741
---
M src/osmo-bsc/bsc_subscr_conn_fsm.c
1 file changed, 20 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/13/26613/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26613
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I234b2a754d0c98031056981823cdbc187e977741
Gerrit-Change-Number: 26613
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211217/925933a8/attachment.htm>