Change in osmo-bsc[master]: lcs: fix bsc_subscr use_count leak

[neels]

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26611 )


Change subject: lcs: fix bsc_subscr use_count leak
......................................................................

lcs: fix bsc_subscr use_count leak

In lcs_ta_req_wait_ta_onenter(), fix use count leak of 'start-paging':
get() the use count only after the early exits.

osmo-ttcn3-hacks patch I69d4c5c6f8d499bb7f0b96a48af045361433c57b
introduces testing against this leak in various LCS tests (e.g.
BSC_Tests.TC_lcs_loc_req_for_active_ms_ta_req).

Related: OS#5355
Change-Id: Ibbfbfe766eafe42c78048ec5b3b503a11ef5535d
---
M src/osmo-bsc/lcs_ta_req.c
1 file changed, 11 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/11/26611/1

diff --git a/src/osmo-bsc/lcs_ta_req.c b/src/osmo-bsc/lcs_ta_req.c
index 6252d46..f0bb02e 100644
--- a/src/osmo-bsc/lcs_ta_req.c
+++ b/src/osmo-bsc/lcs_ta_req.c
@@ -122,17 +122,6 @@
 		return;
 	}
 
-	paging = (struct bsc_paging_params){
-		.reason = BSC_PAGING_FOR_LCS,
-		.msc = loc_req->conn->sccp.msc,
-		.bsub = loc_req->conn->bsub,
-		.tmsi = GSM_RESERVED_TMSI,
-		.imsi = loc_req->req.imsi,
-		.chan_needed = RSL_CHANNEED_ANY,
-	};
-	if (paging.bsub)
-		bsc_subscr_get(paging.bsub, BSUB_USE_PAGING_START);
-
 	/* Do we already have an active lchan with knowledge of TA? */
 	lchan = loc_req->conn->lchan;
 	if (lchan) {
@@ -147,6 +136,17 @@
 		return;
 	}
 
+	paging = (struct bsc_paging_params){
+		.reason = BSC_PAGING_FOR_LCS,
+		.msc = loc_req->conn->sccp.msc,
+		.bsub = loc_req->conn->bsub,
+		.tmsi = GSM_RESERVED_TMSI,
+		.imsi = loc_req->req.imsi,
+		.chan_needed = RSL_CHANNEED_ANY,
+	};
+	if (paging.bsub)
+		bsc_subscr_get(paging.bsub, BSUB_USE_PAGING_START);
+
 	if (!loc_req->req.cell_id_present) {
 		LOG_LCS_TA_REQ(lcs_ta_req, LOGL_DEBUG,
 			       "No Cell Identity in BSSMAP Location Request, paging entire BSS\n");

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26611
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibbfbfe766eafe42c78048ec5b3b503a11ef5535d
Gerrit-Change-Number: 26611
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211217/5f4abde3/attachment.htm>