Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 )

Change subject: First implementation of the LLSK gtp SAPI
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c 
File src/osmo-hnodeb/gtp.c:

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c@126 
PS2, Line 126: }
             : 
             : 	osmo_fd_setup(&hnb->gtp.fd0, gsn->fd0, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 0);
             : 	if ((rc = osmo_fd_register(&hnb->gtp.fd0)) < 0)
             : 		goto free_ret;
             : 
             : 	osmo_fd_setup(&hnb->gtp.fd1c, gsn->fd1c, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 1);
             : 	if ((rc = osmo_fd_register(&hnb->gtp.fd1c)) < 0)
             : 		goto free_ret;
             : 
             : 	osmo_fd_setup(&hnb->gtp.fd1u, gsn->fd1u, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 2);
             : 	if ((rc = osmo_fd_register(&hnb->gtp.fd1u)) < 0)
> * there are no sequence numbers in GTP-U […]
ACK about those.
It's also about managing the socket, the different tunnels/pdps, TEID generation, etc.
If you don't want to have libgtp there I am fine and I can drop it and rewrite it, but using something which already took care of that seemed like a good way to have something working in first place, since I already had to take care of different interfaces, etc. and I wanted to have a first version working soon so that integration can be started.


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c@180 
PS2, Line 180: 		LOG
> one [small] more reason to not use libgtp.
We could fix libgtp to support IPv6 IP/UDP transport here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnodeb
Gerrit-Branch: master
Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366
Gerrit-Change-Number: 26503
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 13 Dec 2021 18:22:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211213/d9106744/attachment.htm>