This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25285 ) Change subject: rsl: parse temporary overpower value RSL CHAN ACT ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/c/osmo-bts/+/25285/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/25285/1//COMMIT_MSG@10 PS1, Line 10: transfered using a propritary RSL IE (RSL_IE_OSMO_TOP_ACCH_CAP). The > transferred, proprietary Done https://gerrit.osmocom.org/c/osmo-bts/+/25285/1/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/25285/1/src/common/rsl.c@1525 PS1, Line 1525: abis_rsl_osmo_top_acch_cap > I'm wondering why are you using a struct if it is only a single uint8_t? is this expected to expand […] As far as I know the temporary overpower is not specified. I am wondering if there might be a need for more specific settings at some point. Also when I started I did not know if I might need some additional flags or so. That is why I started with a struct. We might consider to simplify this and just use an uint8_t without a struct. What do you think? https://gerrit.osmocom.org/c/osmo-bts/+/25285/1/src/common/rsl.c@1529 PS1, Line 1529: if (!TLVP_PRESENT(tp, RSL_IE_OSMO_TOP_ACCH_CAP)) > Ack Done https://gerrit.osmocom.org/c/osmo-bts/+/25285/1/src/common/rsl.c@1838 PS1, Line 1838: parse_temporary_overpower_acch_capability > Ack Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I426c2510865c4a986c68f2027cc676aaac0d8a4c Gerrit-Change-Number: 25285 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 31 Aug 2021 12:19:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210831/a5374c7a/attachment.htm>