This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25270 ) Change subject: osmo-bts-trx: add rate counter for Uplink block decoding errors ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/c/osmo-bts/+/25270/1/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/25270/1/src/common/scheduler.c@694 PS1, Line 694: rate_ctr_group_free(chan_state->ctrs); > what about NULLing the pointer? I see it being done for other fields here. Ack https://gerrit.osmocom.org/c/osmo-bts/+/25270/1/src/common/scheduler.c@1126 PS1, Line 1126: chan_state->ctrs = rate_ctr_group_alloc(l1ts, > no need to free previous field, like done withdl/ul_bursts above? I don't think there is a need for that. https://gerrit.osmocom.org/c/osmo-bts/+/25270/1/src/common/scheduler.c@1129 PS1, Line 1129: snprintf(ctrg_name, sizeof(ctrg_name), "%s %s", > space in the name? are you sure this is correct? I doubt so. This is intended: first %s is the general logical channel name, second %s is the exact channel type. Here is some examples: (bts=0,trx=0,ts=2,ss=0) SACCH/TH(0) (bts=0,trx=0,ts=2,ss=0) TCH/H(0) https://gerrit.osmocom.org/c/osmo-bts/+/25270/1/src/common/scheduler.c@1139 PS1, Line 1139: rate_ctr_group_free(chan_state->ctrs); > set the pointer to null? Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7aea0529771ad73d5d6bcaf0865f9b0d4ecace6b Gerrit-Change-Number: 25270 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 30 Aug 2021 09:20:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210830/94d15009/attachment.htm>