This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25274 ) Change subject: add stat_items for BTS and TRX connection stati ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/25274/1/src/osmo-bsc/bsc_stats.c File src/osmo-bsc/bsc_stats.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25274/1/src/osmo-bsc/bsc_stats.c@156 PS1, Line 156: if (trx_is_usable(trx)) > I don't see the point in your suggestion. The result is going to be the same. […] it's a small optimization, avoiding the trx_is_usable call (which calls other functions) if oml_connected is already set to true. But it's not really important. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25274 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2057a798e681a169cc03243a09b3d6449734c010 Gerrit-Change-Number: 25274 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 30 Aug 2021 09:05:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith at sysmocom.de> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210830/e0ee1b5e/attachment.htm>