This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25102 ) Change subject: tbf: Use type bool for upgrade_to_multislot ...................................................................... tbf: Use type bool for upgrade_to_multislot Change-Id: I644d91b6230a90cc72e83443c11d24b8d0a2dcac --- M src/gprs_rlcmac_ts_alloc.cpp M src/tbf.cpp M src/tbf.h 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp index 5ccbb9f..3c16d8a 100644 --- a/src/gprs_rlcmac_ts_alloc.cpp +++ b/src/gprs_rlcmac_ts_alloc.cpp @@ -421,7 +421,7 @@ tbf_->first_ts = tbf_->first_common_ts = ts; ms_set_reserved_slots(ms, trx, 1 << ts, 1 << ts); - tbf_->upgrade_to_multislot = 0; + tbf_->upgrade_to_multislot = false; bts_do_rate_ctr_inc(bts, CTR_TBF_ALLOC_ALGO_A); return 0; } @@ -945,7 +945,7 @@ tbf_->upgrade_to_multislot = (avail_count > slotcount); LOGPAL(tbf, "B", single, use_trx, LOGL_INFO, "using single slot at TS %d\n", first_ts); } else { - tbf_->upgrade_to_multislot = 0; + tbf_->upgrade_to_multislot = false; LOGPAL(tbf, "B", single, use_trx, LOGL_INFO, "using %d slots\n", slotcount); } diff --git a/src/tbf.cpp b/src/tbf.cpp index 842161c..74a44d9 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -110,7 +110,7 @@ control_ts(0xff), fT(0), num_fT_exp(0), - upgrade_to_multislot(0), + upgrade_to_multislot(false), bts(bts_), m_tfi(0), m_created_ts(0), diff --git a/src/tbf.h b/src/tbf.h index 96a5788..4218cf5 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -265,7 +265,7 @@ } meas; /* Can/should we upgrade this tbf to use multiple slots? */ - uint8_t upgrade_to_multislot; + bool upgrade_to_multislot; /* store the BTS this TBF belongs to */ struct gprs_rlcmac_bts *bts; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I644d91b6230a90cc72e83443c11d24b8d0a2dcac Gerrit-Change-Number: 25102 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210823/69499a56/attachment.htm>