Change in libosmocore[master]: stats: send real last value if no new values come

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Fri Aug 20 11:49:17 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25206 )

Change subject: stats: send real last value if no new values come
......................................................................


Patch Set 4:

> Patch Set 4:
> 
> copying my comments from chat:
> 
> now i still disagree with the way the patch implements it, because it adds state
> 
> there is a bool stats_last_sent_was_max, and IIUC this can only be used from the stats reporter?
> 
> there is a comment claiming that the stat_items can be used from multiple consumers without interfering with each others' state
> 
> IIUC before the patch we report:
> 42, nothing, nothing, nothing...
> after the patch we report:
> 42, 23, nothing, nothing
> I suggest that instead we report:
> 42, 23, 23, 23

That is what "flush period 1" does (send unchanged stats every reporting period)
Setting "flush period 0" disables sending stats that did not change

> because that does not need any state
> (besides the 'next_id' that is already there)


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25206
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibeefd0e3d1dbe4be454ff05a21df4848b2abfabe
Gerrit-Change-Number: 25206
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Aug 2021 11:49:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210820/78891ed6/attachment.htm>


More information about the gerrit-log mailing list