This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25204 ) Change subject: MGCP_Test: do not use module parameter mp_test_ip (statsd) ...................................................................... MGCP_Test: do not use module parameter mp_test_ip (statsd) The module parameter mp_test_ip was added with the following commit: Change-Id I61e23e264bc85eb36d07431c7839fb445c110947 There is already mp_local_ipv4, which has the same function, so we should remove mp_test_ip again and use mp_local_ipv4 to set up the receiving of statsd information. Change-Id: I70f33aed4102c67118cc6701c2578a70c0dfe604 Related: SYS#5535 --- M mgw/MGCP_Test.ttcn 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 3aa7926..b0891f5 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -78,7 +78,6 @@ PortNumber mp_local_rtp_port_base := 10000; PortNumber mp_local_osmux_port := 1985; PortNumber mp_mgw_statsd_port := 8125; - charstring mp_test_ip := "127.0.0.1"; } private function f_vty_enable_osmux(boolean osmux_on) runs on dummy_CT { @@ -150,7 +149,7 @@ connect(vc_OsmuxEM:CTRL, self:OsmuxEM); } - f_init_statsd("VirtCallAgent", vc_STATSD, mp_test_ip, mp_mgw_statsd_port); + f_init_statsd("VirtCallAgent", vc_STATSD, mp_local_ipv4, mp_mgw_statsd_port); connect(self:STATSD_PROC, vc_STATSD:STATSD_PROC); f_statsd_reset(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I70f33aed4102c67118cc6701c2578a70c0dfe604 Gerrit-Change-Number: 25204 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210819/d39d80b0/attachment.htm>