Change in osmo-mgw[master]: mgcp_client_vty: add OSMO_ASSERT on pool parameter

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at

laforge gerrit-no-reply at
Thu Aug 19 14:47:35 UTC 2021

laforge has submitted this change. ( )

Change subject: mgcp_client_vty: add OSMO_ASSERT on pool parameter

mgcp_client_vty: add OSMO_ASSERT on pool parameter

When the function mgcp_client_pool_vty_init is called with pool = NULL,
then it segfaults. Lets put an OSMO_ASSERT() on pool to make clear that
a pool must be present before initalizing the VTY on it.

Change-Id: I36893bf5341d4ad21161e92d2d25d284647f7d18
M src/libosmo-mgcp-client/mgcp_client_vty.c
1 file changed, 3 insertions(+), 0 deletions(-)

  Jenkins Builder: Verified
  laforge: Looks good to me, approved

diff --git a/src/libosmo-mgcp-client/mgcp_client_vty.c b/src/libosmo-mgcp-client/mgcp_client_vty.c
index 7ad1485..7d41ee1 100644
--- a/src/libosmo-mgcp-client/mgcp_client_vty.c
+++ b/src/libosmo-mgcp-client/mgcp_client_vty.c
@@ -517,6 +517,9 @@
  *  \param[in] pool user provided memory to store the configured MGCP client (MGW) pool. */
 void mgcp_client_pool_vty_init(int parent_node, int mgw_node, const char *indent, struct mgcp_client_pool *pool)
+	/* A pool must be allocated before this function can be called */
+	OSMO_ASSERT(pool);
 	/* Never allow this function to be called twice on the same pool */

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I36893bf5341d4ad21161e92d2d25d284647f7d18
Gerrit-Change-Number: 25208
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at>
Gerrit-Reviewer: laforge <laforge at>
Gerrit-Reviewer: neels <nhofmeyr at>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list