This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25201 ) Change subject: early IMM ASS: add configurable delay for RR IMM ASS ...................................................................... Patch Set 4: Code-Review+1 (2 comments) I did not test this but it looks meaningful to me. I guess you made sure that this still passes the TTCN3 tests. https://gerrit.osmocom.org/c/osmo-bts/+/25201/4/src/common/lchan.c File src/common/lchan.c: https://gerrit.osmocom.org/c/osmo-bts/+/25201/4/src/common/lchan.c@34 PS4, Line 34: /* The IA message has disappeared since the timer was started. */ I guess this can happen from time to time. If this is an odd situation, maybe a debug log message might be a good idea? https://gerrit.osmocom.org/c/osmo-bts/+/25201/4/src/common/lchan.c@78 PS4, Line 78: osmo_tdef_get(abis_T_defs, -15, OSMO_TDEF_US, -1)); The -15 looks a bit strange on the first look, but I found it in abis_T_defs[], We do not use define constants for that in this case i guess. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25201 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia1e63b98944dc840cde212fc732e20277cdc5585 Gerrit-Change-Number: 25201 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-CC: Hoernchen <ewild at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 18 Aug 2021 15:06:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210818/d713b344/attachment.htm>