Change in osmo-bsc[master]: osmo_bsc_main: remove unused commandline option -l

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Mon Aug 9 09:36:07 UTC 2021


dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25122 )

Change subject: osmo_bsc_main: remove unused commandline option -l
......................................................................

osmo_bsc_main: remove unused commandline option -l

The option -l ("The local address of the MGCP") is still present in the
commandline help and the manual, but it is used nowhere and osmo-bsc
exists when it is used. Lets remove it.

Change-Id: Ia295f4414e0d6e78b388c0c72f1a5b8df8bc3d7e
---
M doc/manuals/chapters/running.adoc
M src/osmo-bsc/osmo_bsc_main.c
2 files changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve
  daniel: Looks good to me, approved



diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc
index 3e48c4a..327e0bd 100644
--- a/doc/manuals/chapters/running.adoc
+++ b/doc/manuals/chapters/running.adoc
@@ -35,8 +35,6 @@
 	Set the global log level for logging to stderr. This has mostly
 	been deprecated by VTY based logging configuration, see
 	<<logging>> for more information.
-*-l, --local='IP'*::
-	Specify the local IP address of the OsmoBSC-MGCP
 *-r, --rf-ctl 'RFCTL'*::
 	Offer a Unix domain socket for RF control at the path/filename
 	'RFCTL' in the file system.
diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index 2a6c501..b97c7a1 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -104,7 +104,6 @@
 	printf("  -T --timestamp		Print a timestamp in the debug output.\n");
 	printf("  -V --version               	Print the version of OsmoBSC.\n");
 	printf("  -c --config-file filename	The config file to use.\n");
-	printf("  -l --local IP			The local address of the MGCP.\n");
 	printf("  -e --log-level number		Set a global loglevel.\n");
 	printf("  -r --rf-ctl NAME		A unix domain socket to listen for cmds.\n");
 	printf("  -t --testmode			A special mode to provoke failures at the MSC.\n");
@@ -152,7 +151,6 @@
 			{"disable-color", 0, 0, 's'},
 			{"timestamp", 0, 0, 'T'},
 			{"version", 0, 0, 'V' },
-			{"local", 1, 0, 'l'},
 			{"log-level", 1, 0, 'e'},
 			{"rf-ctl", 1, 0, 'r'},
 			{"testmode", 0, 0, 't'},

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25122
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia295f4414e0d6e78b388c0c72f1a5b8df8bc3d7e
Gerrit-Change-Number: 25122
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210809/829286a3/attachment.htm>


More information about the gerrit-log mailing list