Change in osmo-mgw[master]: libosmo-mgcp-client: extend the mgcp_client for MGW pooling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at

osmith gerrit-no-reply at
Thu Aug 5 12:21:41 UTC 2021

osmith has posted comments on this change. ( )

Change subject: libosmo-mgcp-client: extend the mgcp_client for MGW pooling

Patch Set 8:


only some cosmetics, rest looks good! thanks for answering everything in detail, makes sense. 
File src/libosmo-mgcp-client/mgcp_client_pool.c: 
PS5, Line 159: 	 *  not belong to a pool at all, the function call will have no effect. */
> I think that is done automatically by doxygen. […]
What I meant is, I'd move this comment above "void mgcp_client_pool_put(...". like here: 
File src/libosmo-mgcp-client/mgcp_client_pool.c: 
PS8, Line 133: 	 *  by the application code. */
(Move above struct mgcp_client *mgcp_client_pool_get, see other comment?) 
File src/libosmo-mgcp-client/mgcp_client_vty.c: 
PS5, Line 50:  \
> I have to use this macro in each (common) VTY command to get the pointer to the conf. […]
but why not a function instead of a macro? 
PS5, Line 329:  
> The extra space is on purpose. […]
sorry I got confused about the snprintf arguments. global_mgcp_client_indent_pool gets read, not written to. FWIW I think it is more readable in the new version without the global variable. 
PS5, Line 531: indent
> I would normally expect the indent string to be a constant, but who knows where an API user is getti […]
(nvm the strdup comment, I thought global_mgcp_client_indent_pool would get written to... but now I see that it was only read.) 
File src/libosmo-mgcp-client/mgcp_client_vty.c: 
PS8, Line 38: connands

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icaaba0e470e916eefddfee750b83f5f65291a6b0
Gerrit-Change-Number: 25120
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at>
Gerrit-Reviewer: neels <nhofmeyr at>
Gerrit-Reviewer: osmith <osmith at>
Gerrit-Reviewer: pespin <pespin at>
Gerrit-Comment-Date: Thu, 05 Aug 2021 12:21:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at>
Comment-In-Reply-To: dexter <pmaier at>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list