Change in osmo-mgw[master]: mgcp_client: allow to reset endpoints on startup

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at

dexter gerrit-no-reply at
Mon Aug 2 11:08:55 UTC 2021

dexter has posted comments on this change. ( )

Change subject: mgcp_client: allow to reset endpoints on startup

Patch Set 8:

File src/libosmo-mgcp-client/mgcp_client.c: 
PS7, Line 912: }
> moving this function seems like an unrelated change, maybe put it in a separate commit?
Its not unrelated, I need this function in mgcp_client_connect now, which is more up. That is why I moved it. 
PS7, Line 856: Fromat
> Format
File src/libosmo-mgcp-client/mgcp_client_vty.c: 
PS7, Line 178: 	for (i = 0; i < strlen(argv[0]); i++) {
> How about, instead of the for and if: […]
PS7, Line 193: 		return CMD_WARNING;
> reset_ep is not deallocated in this code path
PS7, Line 204:       MGW_STR "emove an endpoint name from the reset-endpoint list, e.g. 'rtpbridge/*'\n"
> "emove -> "remove

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I47e7ff858d5067b46d52329be5f362ff61c0dff8
Gerrit-Change-Number: 25008
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at>
Gerrit-Reviewer: pespin <pespin at>
Gerrit-CC: neels <nhofmeyr at>
Gerrit-CC: osmith <osmith at>
Gerrit-Comment-Date: Mon, 02 Aug 2021 11:08:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list