This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23832 ) Change subject: osmo-bts-trx: refactor handling of version specific TRXD parts ...................................................................... Patch Set 6: Code-Review+2 (1 comment) 1+1 https://gerrit.osmocom.org/c/osmo-bts/+/23832/6/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/23832/6/src/osmo-bts-trx/trx_if.c@737 PS6, Line 737: bi->fn = osmo_load32be(buf + 1); > I know it was already this way before, but I find this mixture of buf[x] and buf +x in each line a b […] To me there is absolutely no difference in readability, both variants doing the same thing. I prefer to use the former when it's expected that only one octet will be read and/or written, and the later when several octets staring from position +x will be processed. Given that you are usually not happy against the later, I recently started to use &buf[x] in the most cases. Otherwise it's less likely to get CR+1 from you :D -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23832 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7aedd85a8d4f6d6191cd3b75272a688208fb2879 Gerrit-Change-Number: 23832 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 30 Apr 2021 19:02:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210430/dd718008/attachment.htm>