This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/23983 ) Change subject: xua_as_fsm: Only delete a route for an IPA AS if we created one earlier ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/libosmo-sccp/+/23983/2/src/xua_as_fsm.c File src/xua_as_fsm.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/23983/2/src/xua_as_fsm.c@236 PS2, Line 236: if (osmo_ss7_route_create(inst->rtable_system, as->cfg.routing_key.pc, 0xffffff, as->cfg.name)) Did you think about storing the pointer of the route instead of a bool? then you don't need to look it up later in ipa_del_route below. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/23983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I9ad5f7ebe0790e6c186b8ea1b12f204860a00cd2 Gerrit-Change-Number: 23983 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 29 Apr 2021 18:08:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210429/27dd6729/attachment.htm>