This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/23982 ) Change subject: osmo_ss7: Truncate route 'mask' to point code bit length ...................................................................... osmo_ss7: Truncate route 'mask' to point code bit length Otherwise we run into the problem that a route with mask 0xffffff differs from one with a mask of 0x3fff despite having only 14 bit point code length and them being logically equal. Change-Id: I5d5c828de45724d93a0461bb0dd7858fd8378acd Related: SYS#5422 --- M src/osmo_ss7.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/82/23982/1 diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 98dfc0c..443dc39 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -775,6 +775,10 @@ struct osmo_ss7_linkset *lset; struct osmo_ss7_as *as = NULL; + /* truncate mask to maximum. Let's avoid callers specifying arbitrary large + * masks to ensure we don't fail duplicate detection with longer mask lengths */ + mask &= (1 << osmo_ss7_pc_width(&rtbl->inst->cfg.pc_fmt))-1; + OSMO_ASSERT(ss7_initialized); lset = osmo_ss7_linkset_find_by_name(rtbl->inst, linkset_name); if (!lset) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/23982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I5d5c828de45724d93a0461bb0dd7858fd8378acd Gerrit-Change-Number: 23982 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210429/37d1c01c/attachment.htm>