This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23934 ) Change subject: socket: QoS support for all our socket init functions ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+1 > > I'd probably prefer having a new generic api with 2 extra params (=-1 do nothing), and point old APIs to use that one internally. I thought of that, but then functions with ever growing arguments lists are also not partcularly nice either... And the benefit here si that it work with _all_ the many different variants of socket related APIS. I guess your eapproach would easily introduce something like 6 new function signatures, with even more old wrappers pointing to new functions. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If22988735fe05e51226c6b091a5348dcf1208cdf Gerrit-Change-Number: 23934 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 28 Apr 2021 12:37:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210428/daa4f032/attachment.htm>