Change in osmo-pcu[master]: ul_tbf: Clean up handle_tbf_reject()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Apr 27 09:50:08 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23907 )

Change subject: ul_tbf: Clean up handle_tbf_reject()
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/23907/3/src/tbf_ul.cpp 
File src/tbf_ul.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/23907/3/src/tbf_ul.cpp@152 
PS3, Line 152: 		/* Caller will most probably send a Imm Ass Reject after return */
I would keep FIXME here, or add TODO instead?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23907
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I61df2e4f0f0df1f8db941741a2d35a2319252c5e
Gerrit-Change-Number: 23907
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 27 Apr 2021 09:50:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210427/72e1ee6d/attachment.htm>


More information about the gerrit-log mailing list