This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23829 ) Change subject: osmo-bts-trx: discard TRXD PDUs with unexpected version ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/23829/4/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/23829/4/src/osmo-bts-trx/trx_if.c@970 PS4, Line 970: OSMO_ASSERT(0); > it CAN happen though. Doesn't look like the correct thing to do here, just killing the process. This may only happen if 'l1h->config.trxd_pdu_ver_use' contains an unknown version. And this would be a serious bug: if you negotiate an unknown version, there is no point to continue running - you won't be able to decode even a single burst anyway. So why should we tolerate this? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icdc3d12a7686428046113f9fa8f21a99569e651a Gerrit-Change-Number: 23829 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 23 Apr 2021 15:00:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210423/12f1f336/attachment.htm>