This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23819 ) Change subject: utils: fix encoding of EF.MSISDN ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/pysim/+/23819/1/pySim/utils.py File pySim/utils.py: https://gerrit.osmocom.org/c/pysim/+/23819/1/pySim/utils.py@412 PS1, Line 412: not msisdn or msisdn == "" It cannot be None (according to the type hint for 'msisdn'), so both statements are equivalent. This I would remove one of them. https://gerrit.osmocom.org/c/pysim/+/23819/1/pySim/utils.py@420 PS1, Line 420: Truncate overlong MSISDN I don't think it's a good idea to silently truncate something, better raise an exception here. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23819 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iee5369b3e3ba7fa1155facc8fa824bc60e33b55b Gerrit-Change-Number: 23819 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Tue, 20 Apr 2021 22:00:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210420/dcd3c89c/attachment.htm>