This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23804 ) Change subject: gsm48_mr_cfg_from_gsm0808_sc_cfg(): drop bitmask without effect ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/23804/1/src/gsm/gsm0808_utils.c File src/gsm/gsm0808_utils.c: https://gerrit.osmocom.org/c/libosmocore/+/23804/1/src/gsm/gsm0808_utils.c@1582 PS1, Line 1582: if (s15_s0 & GSM0808_SC_CFG_AMR_4_75_5_90_7_40_12_20) { I have checked this back. The constant GSM0808_SC_CFG_AMR_4_75_5_90_7_40_12_20 is defined as 0x0002. So the mask has indeed no effect, however its probably there to make clear that in the comparison only the lower 8 bit matter. I would write 0x00ff to make it even more clearer, but thats a personal opinion. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia25ac20539e8ac70fb5f70c1191bd58825151c68 Gerrit-Change-Number: 23804 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 20 Apr 2021 09:31:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210420/80cfdeac/attachment.htm>