This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23804 ) Change subject: gsm48_mr_cfg_from_gsm0808_sc_cfg(): drop bitmask without effect ...................................................................... gsm48_mr_cfg_from_gsm0808_sc_cfg(): drop bitmask without effect GSM0808_SC_CFG_AMR_4_75_5_90_7_40_12_20 has value 0x0002, so the '& 0xff' had exactly no effect. Change-Id: Ia25ac20539e8ac70fb5f70c1191bd58825151c68 --- M src/gsm/gsm0808_utils.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/23804/1 diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c index dda73ad..94c9a79 100644 --- a/src/gsm/gsm0808_utils.c +++ b/src/gsm/gsm0808_utils.c @@ -1579,7 +1579,7 @@ /* Rate 5,15k can never be selected (see table) */ cfg->m5_15 = 0; - if (s15_s0 & GSM0808_SC_CFG_AMR_4_75_5_90_7_40_12_20 & 0xff) { + if (s15_s0 & GSM0808_SC_CFG_AMR_4_75_5_90_7_40_12_20) { /* Table Table 7.11.3.1.3-2 lists one mode that selects 4 * rates at once (Config-NB-Code = 1). The rates selected * are known to be compatible between GERAN and UTRAN, since -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia25ac20539e8ac70fb5f70c1191bd58825151c68 Gerrit-Change-Number: 23804 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210419/c7e94dca/attachment.htm>