This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/23778 ) Change subject: vty_{client,server}_init(): remove unused argument ...................................................................... vty_{client,server}_init(): remove unused argument Change-Id: I65256c8602e91bcdbe5fe9e532b6ce7d347d3980 --- M include/osmo-pcap/osmo_pcap_client.h M include/osmo-pcap/osmo_pcap_server.h M src/osmo_client_main.c M src/osmo_client_vty.c M src/osmo_server_main.c M src/osmo_server_vty.c 6 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmo-pcap/osmo_pcap_client.h b/include/osmo-pcap/osmo_pcap_client.h index 70be8db..887d422 100644 --- a/include/osmo-pcap/osmo_pcap_client.h +++ b/include/osmo-pcap/osmo_pcap_client.h @@ -107,7 +107,7 @@ extern struct osmo_pcap_client *pcap_client; struct osmo_pcap_client *osmo_pcap_client_alloc(void *tall_ctx); -int vty_client_init(struct osmo_pcap_client *); +int vty_client_init(void); int osmo_client_capture(struct osmo_pcap_client *client, const char *device); int osmo_client_filter(struct osmo_pcap_client *client, const char *filter); diff --git a/include/osmo-pcap/osmo_pcap_server.h b/include/osmo-pcap/osmo_pcap_server.h index a983ec5..7de94a6 100644 --- a/include/osmo-pcap/osmo_pcap_server.h +++ b/include/osmo-pcap/osmo_pcap_server.h @@ -144,7 +144,7 @@ struct osmo_pcap_conn *osmo_pcap_server_find(struct osmo_pcap_server *ser, const char *name); void osmo_pcap_server_delete(struct osmo_pcap_conn *conn); -void vty_server_init(struct osmo_pcap_server *server); +void vty_server_init(void); void osmo_pcap_server_close_trace(struct osmo_pcap_conn *conn); void osmo_pcap_server_close_conn(struct osmo_pcap_conn *conn); diff --git a/src/osmo_client_main.c b/src/osmo_client_main.c index cbaefef..7ca3548 100644 --- a/src/osmo_client_main.c +++ b/src/osmo_client_main.c @@ -234,7 +234,7 @@ logging_vty_add_cmds(); osmo_stats_vty_add_cmds(); osmo_talloc_vty_add_cmds(); - vty_client_init(tall_cli_ctx); + vty_client_init(); /* parse options */ handle_options(argc, argv); diff --git a/src/osmo_client_vty.c b/src/osmo_client_vty.c index fed9bf6..7458f85 100644 --- a/src/osmo_client_vty.c +++ b/src/osmo_client_vty.c @@ -519,7 +519,7 @@ } -int vty_client_init(struct osmo_pcap_client *pcap) +int vty_client_init(void) { install_element(CONFIG_NODE, &cfg_client_cmd); install_node(&client_node, config_write_client); diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c index f8850db..9c234d5 100644 --- a/src/osmo_server_main.c +++ b/src/osmo_server_main.c @@ -247,7 +247,7 @@ logging_vty_add_cmds(); osmo_stats_vty_add_cmds(); osmo_talloc_vty_add_cmds(); - vty_server_init(tall_srv_ctx); + vty_server_init(); /* parse options */ handle_options(argc, argv); diff --git a/src/osmo_server_vty.c b/src/osmo_server_vty.c index e9b54b1..87bcfa2 100644 --- a/src/osmo_server_vty.c +++ b/src/osmo_server_vty.c @@ -513,7 +513,7 @@ return CMD_SUCCESS; } -void vty_server_init(struct osmo_pcap_server *server) +void vty_server_init(void) { install_element(CONFIG_NODE, &cfg_server_cmd); install_node(&server_node, config_write_server); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/23778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I65256c8602e91bcdbe5fe9e532b6ce7d347d3980 Gerrit-Change-Number: 23778 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210418/dee1152a/attachment.htm>