This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23774 ) Change subject: osmo-bts-trx: correct definition of 'osmotrx rx-gain' command ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/23774/1/src/osmo-bts-trx/trx_vty.c File src/osmo-bts-trx/trx_vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/23774/1/src/osmo-bts-trx/trx_vty.c@357 PS1, Line 357: l1h->config.rxgain_sent = false; > Ideally we should add a new FSM events to "enum trx_provision_fsm_events" in order to be able to con […] Not sure if it's really that important to be able to change Rx gain at run-time. My intention is to fix confusing VTY attributes here. Also, having a separate event for every possible parameter looks redundant to me. It could be just a single event passed with a pointer to a structure with parameter description. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I93c9e19d0543f19528cec842b8be332b4d93214e Gerrit-Change-Number: 23774 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 16 Apr 2021 14:32:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210416/8a851780/attachment.htm>