Change in osmocom-bb[master]: trx_toolkit: define TRXDv2 PDUs using declarative codec

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/23678 )

Change subject: trx_toolkit: define TRXDv2 PDUs using declarative codec
......................................................................

trx_toolkit: define TRXDv2 PDUs using declarative codec

Change-Id: If356d285006c0b9b57879d0499b8144eca820cab
Related: OS#4006, SYS#4895
---
M src/target/trx_toolkit/trxd_proto.py
1 file changed, 88 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/target/trx_toolkit/trxd_proto.py b/src/target/trx_toolkit/trxd_proto.py
index aef3351..80d8de8 100644
--- a/src/target/trx_toolkit/trxd_proto.py
+++ b/src/target/trx_toolkit/trxd_proto.py
@@ -30,12 +30,20 @@
 class Header(codec.BitFieldSet):
 	''' Header constructor for TRXD PDUs. '''
 
-	def __init__(self, ver: int):
-		codec.BitFieldSet.__init__(self, len=1, set=(
-			codec.BitField('ver', bl=4, val=ver),
-			codec.BitField.Pad(bl=1), # RFU
+	def __init__(self, ver: int, batched: bool = False):
+		f = [ # Dynamically generated field list
+			codec.BitField('ver', bl=4, val=ver) if not batched
+				else codec.BitField.Spare(bl=4), # RFU
+			codec.BitField.Spare(bl=1),
 			codec.BitField('tn', bl=3),
-		))
+		]
+
+		if ver >= 2: # TRXDv2 and higher
+			f.append(codec.BitField('batch', bl=1))
+			f.append(codec.BitField.Spare(bl=1))
+			f.append(codec.BitField('trxn', bl=6))
+
+		codec.BitFieldSet.__init__(self, set=tuple(f))
 
 class MTS(codec.BitFieldSet):
 	''' Modulation and Training Sequence. '''
@@ -53,8 +61,10 @@
 
 		GMSK_BURST_LEN = 148
 
-		if (mod >> 2) in (0b00, 0b11): # GMSK or AQPSK
+		if (mod >> 2) == 0b00: # GMSK
 			return 1 * GMSK_BURST_LEN
+		elif (mod >> 2) == 0b11: # AQPSK
+			return 2 * GMSK_BURST_LEN
 		elif (mod >> 1) == 0b010: # 8-PSK
 			return 3 * GMSK_BURST_LEN
 		elif (mod >> 1) == 0b100: # 16QAM
@@ -65,6 +75,35 @@
 			return 1 * GMSK_BURST_LEN
 		raise ValueError('Unknown modulation type')
 
+class Power(codec.Codec):
+	''' SCPIR and Tx power reduction (TRXDv2 and higher).
+
+	+-----------------+---------------------------------+
+	| 7 6 5 4 3 2 1 0 | Description                     |
+	+-----------------+---------------------------------+
+	| . . . . x x x x | Power REDuction (in 2 dB steps) |
+	+-----------------+---------------------------------+
+	| . x x x . . . . | SCPIR value (in 2 dB steps)     |
+	+-----------------+---------------------------------+
+	| x . . . . . . . | SCPIR sign indicator            |
+	+-----------------+---------------------------------+
+
+	'''
+
+	def from_bytes(self, vals: dict, data: bytes) -> int:
+		blob = ord(data) # Convert a byte to an int
+		vals['red'] = (blob & 0b1111) * 2
+		vals['scpir'] = ((blob >> 4) & 0b111) * 2
+		if blob & (1 << 7): # negative sign
+			vals['scpir'] *= -1
+		return 1
+
+	def to_bytes(self, vals: dict) -> bytes:
+		blob = (vals['red'] & 0b1111) \
+		     | (abs(vals['scpir']) << 4) // 2 \
+		     | (0x80 if (vals['scpir'] < 0) else 0x00)
+		return bytes((blob,))
+
 class BurstBits(codec.Buf):
 	''' Soft-/hard-bits with variable length. '''
 
@@ -118,3 +157,46 @@
 	def __init__(self, *args, **kw):
 		PDUv0Tx.__init__(self, *args, **kw)
 		self.STRUCT[0]._fields[0].val = 1
+
+
+class PDUv2Rx(codec.Envelope):
+	class BPDU(codec.Envelope):
+		''' Batched PDU part. '''
+		STRUCT = (
+			Header(ver=2, batched=True),
+			MTS(),
+			codec.Uint('rssi', mult=-1),
+			codec.Int16BE('toa256'),
+			codec.Int16BE('cir'),
+			BurstBits('soft-bits'),
+		)
+
+	STRUCT = (
+		Header(ver=2),
+		MTS(),
+		codec.Uint('rssi', mult=-1),
+		codec.Int16BE('toa256'),
+		codec.Int16BE('cir'),
+		codec.Uint32BE('fn'),
+		BurstBits('soft-bits'),
+		codec.Sequence(item=BPDU()).f('bpdu'),
+	)
+
+class PDUv2Tx(codec.Envelope):
+	class BPDU(codec.Envelope):
+		''' Batched PDU part. '''
+		STRUCT = (
+			Header(ver=2, batched=True),
+			MTS(),
+			Power(),
+			BurstBits('hard-bits'),
+		)
+
+	STRUCT = (
+		Header(ver=2),
+		MTS(),
+		Power(),
+		codec.Uint32BE('fn'),
+		BurstBits('hard-bits'),
+		codec.Sequence(item=BPDU()).f('bpdu'),
+	)

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/23678
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: If356d285006c0b9b57879d0499b8144eca820cab
Gerrit-Change-Number: 23678
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210412/7f94cf25/attachment.htm>