Change in pysim[master]: ts_31_102: Fix decode_select_response() for DF.5GS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Apr 2 19:10:07 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/23580 )

Change subject: ts_31_102: Fix decode_select_response() for DF.5GS
......................................................................

ts_31_102: Fix decode_select_response() for DF.5GS

In Change-Id I848a766e6d00be497c7db905475e0681cce197ac we added a CardDF
instance for DF_5GS.  That DF should not have provided a
decode_select_response() method, and instead fall back to that of the
base class, which calls the method of the parent directory (ADF_USIM).

The difference is illustrated below

pySIM-shell (MF/ADF.USIM/EF.IMSI)> select DF.5GS
"622e8202782183025fc0a509800171830400018d088a01058c056611111111c60f90017083010183018183010a83010b"

vs. (with this patch):

pySIM-shell (MF/ADF.USIM)> select DF.5GS
{
    "file_descriptor": {
        "shareable": true,
        "file_type": "df",
        "structure": "no_info_given"
    },
    "file_identifier": "5FC0",
    "proprietary_info": {
        "uicc_characteristics": "71",
        "available_memory": 101640
    },
    "life_cycle_status_int": "operational_activated",
    "security_attrib_compact": "6611111111",
    "pin_status_template_do": "90017083010183018183010A83010B"
}

Change-Id: I80612711bbc8c47285a828a0759b20beea6619f1
---
M pySim/ts_31_102.py
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py
index 9febaf7..cefc9d4 100644
--- a/pySim/ts_31_102.py
+++ b/pySim/ts_31_102.py
@@ -479,9 +479,6 @@
 
         self.add_files(files)
 
-    def decode_select_response(self, data_hex):
-        return data_hex
-
 class ADF_USIM(CardADF):
     def __init__(self, aid='a0000000871002', name='ADF.USIM', fid=None, sfid=None,
                  desc='USIM Application'):

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23580
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I80612711bbc8c47285a828a0759b20beea6619f1
Gerrit-Change-Number: 23580
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: merlinchlosta <merlin.chlosta at rub.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210402/9c7f0901/attachment.htm>


More information about the gerrit-log mailing list