Change in osmo-bsc[master]: Ignore CHANnel ReQuireD with Access Delay IE > 63

[keith]

keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23574 )


Change subject: Ignore CHANnel ReQuireD with Access Delay IE > 63
......................................................................

Ignore CHANnel ReQuireD with Access Delay IE > 63

It is observed that a CHANnel ReQuireD with access delay
greater than 63 can be received from the Ericsson RBS.
This results in osmo-bsc sending back a CHANnel ACTIVation with
a Timing Advance IE containing the access delay value.
The RBS NACKs this, leading to a BORKEN Channel.

This patch makes the maximum acceptable access delay vty-configurable
and Ignores CHANnel ReQuireD RSL Messages with Access Delay IE greater
than that configured. Default value is 63.

Change-Id: Ie8987bcc0e43921bc753162b77a0efc68799b3ce
---
M include/osmocom/bsc/bts.h
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/bts.c
4 files changed, 29 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/74/23574/1

diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h
index f40aa3e..e44c51e 100644
--- a/include/osmocom/bsc/bts.h
+++ b/include/osmocom/bsc/bts.h
@@ -529,6 +529,9 @@
 	/* MS/BS Power Control parameters */
 	struct gsm_power_ctrl_params ms_power_ctrl;
 	struct gsm_power_ctrl_params bs_power_ctrl;
+
+	/* We will ignore CHAN RQD with access delay greater than rach_max_delay */
+	uint8_t rach_max_delay;
 };
 
 #define GSM_BTS_SI2Q(bts, i)   (struct gsm48_system_information_type_2quater *)((bts)->si_buf[SYSINFO_TYPE_2quater][i])
diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 67e7d27..6027198 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1526,6 +1526,12 @@
 		return -EINVAL;
 	}
 	rqd->ta = rqd_hdr->data[sizeof(struct gsm48_req_ref)+2];
+        if (rqd->ta > bts->rach_max_delay) {
+		LOG_BTS(bts, DRSL, LOGL_NOTICE, "Ignoring CHAN RQD: Access Delay(%d) greater than %u\n",
+			rqd->ta, bts->rach_max_delay);
+		talloc_free(rqd);
+		return -EINVAL;
+	}
 
 	/* Determine channel request cause code */
 	rqd->reason = get_reason_by_chreq(rqd->ref.ra, bts->network->neci);
diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 280fe9f..7abb5a4 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -433,6 +433,8 @@
 	vty_out(vty, "  RACH Max transmissions: %u%s",
 		rach_max_trans_raw2val(bts->si_common.rach_control.max_trans),
 		VTY_NEWLINE);
+	vty_out(vty, "  RACH Max Delay (Max TA IE in CHANnel ReQuireD): %u%s",
+		bts->rach_max_delay, VTY_NEWLINE);
 	if (bts->si_common.rach_control.cell_bar)
 		vty_out(vty, "  CELL IS BARRED%s", VTY_NEWLINE);
 	if (bts->dtxu != GSM48_DTX_SHALL_NOT_BE_USED)
@@ -1041,6 +1043,7 @@
 	vty_out(vty, "  rach max transmission %u%s",
 		rach_max_trans_raw2val(bts->si_common.rach_control.max_trans),
 		VTY_NEWLINE);
+	vty_out(vty, "  rach max delay %u%s", bts->rach_max_delay, VTY_NEWLINE);
 
 	vty_out(vty, "  channel-description attach %u%s",
 		bts->si_common.chan_desc.att, VTY_NEWLINE);
@@ -2746,6 +2749,20 @@
 	return CMD_SUCCESS;
 }
 
+DEFUN_USRATTR(cfg_bts_rach_max_delay,
+	      cfg_bts_rach_max_delay_cmd,
+	      X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK),
+	      "rach max delay <0-127>",
+	      RACH_STR
+	      "Set the max TA IE value to accept in CHANnel ReQuireD\n"
+	      "Set the max TA IE value to accept in CHANnel ReQuireD\n"
+	      "Maximum TA IE value to accept in CHANnel ReQuireD\n")
+{
+	struct gsm_bts *bts = vty->index;
+	bts->rach_max_delay = atoi(argv[0]);
+	return CMD_SUCCESS;
+}
+
 #define REP_ACCH_STR "FACCH/SACCH repetition\n"
 
 DEFUN_USRATTR(cfg_bts_rep_dl_facch,
@@ -7668,6 +7685,7 @@
 	install_element(BTS_NODE, &cfg_bts_challoc_cmd);
 	install_element(BTS_NODE, &cfg_bts_rach_tx_integer_cmd);
 	install_element(BTS_NODE, &cfg_bts_rach_max_trans_cmd);
+	install_element(BTS_NODE, &cfg_bts_rach_max_delay_cmd);
 	install_element(BTS_NODE, &cfg_bts_chan_desc_att_cmd);
 	install_element(BTS_NODE, &cfg_bts_chan_dscr_att_cmd);
 	install_element(BTS_NODE, &cfg_bts_chan_desc_bs_pa_mfrms_cmd);
diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index 398f26f..6076267 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -357,6 +357,8 @@
 	bts->bs_power_ctrl = power_ctrl_params_def;
 	bts->bs_power_ctrl.dir = GSM_PWR_CTRL_DIR_DL;
 
+	bts->rach_max_delay = 63;
+
 	return bts;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23574
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie8987bcc0e43921bc753162b77a0efc68799b3ce
Gerrit-Change-Number: 23574
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210402/08835488/attachment.htm>