This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23466 ) Change subject: BTS_Tests: refactor and fix TC_pcu_socket_connect_multi ...................................................................... BTS_Tests: refactor and fix TC_pcu_socket_connect_multi The expectations of this test case were wrong. The IUT would first accept() an additional connection and then close() it immediately. Since there may be other messages, like TIME.ind and DATA.ind, the 'alt' statement would not match successful connection result, and instead would unblock the flow due to timeout. The titan.TestPorts.UNIX_DOMAIN_SOCKETasp had to be changed [1] to send UD_connect_result with ERROR if recv() returns zero or a negative. [1] https://github.com/eclipse/titan.TestPorts.UNIX_DOMAIN_SOCKETasp/pull/4 Change-Id: I898b8b14515d79766b12d652ebb1ddf834e2863c --- M bts/BTS_Tests.ttcn M deps/Makefile 2 files changed, 21 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index c0ec728..555fe0c 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -5465,25 +5465,39 @@ /* Ensure that PCUIF socket can accept only a single connection */ testcase TC_pcu_socket_connect_multi() runs on test_CT { + var boolean connected := false; + var UD_connect_result cr; + var integer cid; timer T := 5.0; + var template UD_Result tr_ok := { result_code := SUCCESS, err := omit }; + var template UD_Result tr_err := { result_code := ERROR, err := ? }; + /* this (among other things) establishes the first connection to the PCUIF socket */ f_init_with_pcuif(); - /* try to establish a second connection, expect it to fail */ + /* try to establish a second connection */ PCU.send(UD_connect:{mp_pcu_socket, -1}); T.start; alt { - [] PCU.receive(UD_connect_result:{id := ?, result := { result_code := ERROR, err := ? }}) { + /* the IUT will first accept() the new connection, and close() it immediately */ + [not connected] PCU.receive(UD_connect_result:{ id := ?, result := tr_ok }) -> value cr { + log("BTS has accept()ed connection"); + connected := true; + cid := cr.id; + repeat; + } + [connected] PCU.receive(UD_connect_result:{ id := cid, result := tr_err }) { + log("BTS has close()d connection"); setverdict(pass); } - [] PCU.receive(UD_connect_result:?) { - setverdict(fail, "Unexpected unix domain connect result"); - } + /* ignore other messages related to the first connection */ + [] PCU.receive { repeat; } [] T.timeout { - setverdict(pass); + setverdict(fail, "Timeout waiting for connection result"); } } + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } diff --git a/deps/Makefile b/deps/Makefile index 9057463..c63dca7 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -126,7 +126,7 @@ titan.TestPorts.TCPasp_commit= R.9.A-5-g2c91bc6 titan.TestPorts.TELNETasp_commit= 873fe539642542cd9a901c208f1ec11c6d2f5387 titan.TestPorts.UDPasp_commit= c20d77a34f288dd70dd4aaa30e520778876e9336 -titan.TestPorts.UNIX_DOMAIN_SOCKETasp_commit= R.2.A-8-g7ec4fe0 +titan.TestPorts.UNIX_DOMAIN_SOCKETasp_commit= R.2.A-13-gd34ab71 titan.TestPorts.USB_commit= master osmo-uecups_commit= master -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23466 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I898b8b14515d79766b12d652ebb1ddf834e2863c Gerrit-Change-Number: 23466 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210401/20c9b50f/attachment.htm>