Change in osmocom-bb[master]: fix compilation with arm-none-eabi 8.3.1 20190703 on Debian unstable

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Sep 30 12:08:52 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/20300 )

Change subject: fix compilation with arm-none-eabi 8.3.1 20190703 on Debian unstable
......................................................................

fix compilation with arm-none-eabi 8.3.1 20190703 on Debian unstable

To make the situation about stdint.h even more complicated, this
toolchain doesn't anymore #define __int8_t_defined, which means
we again run into conflicting definitions :/

Let's try to use INT8_MAX as a key.

Change-Id: I1a74cdcd03366390e88b2d5bddf01329410b9f1c
---
M src/target/firmware/include/stdint.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/target/firmware/include/stdint.h b/src/target/firmware/include/stdint.h
index 627403f..5997f43 100644
--- a/src/target/firmware/include/stdint.h
+++ b/src/target/firmware/include/stdint.h
@@ -19,7 +19,7 @@
 #include_next <stdint.h>
 #endif
 
-#ifndef __int8_t_defined
+#if (!defined(__int8_t_defined) && !defined(INT8_MAX))
 typedef signed char int8_t;
 typedef unsigned char uint8_t;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20300
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1a74cdcd03366390e88b2d5bddf01329410b9f1c
Gerrit-Change-Number: 20300
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200930/5f68b35d/attachment.htm>


More information about the gerrit-log mailing list