Change in osmo-bts[master]: vty: cosmetic: use osmo_talloc_replace_string()

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20287 )

Change subject: vty: cosmetic: use osmo_talloc_replace_string()
......................................................................

vty: cosmetic: use osmo_talloc_replace_string()

Change-Id: Ic195cef2aafec55d37152045f7714335ded0a62b
---
M src/common/vty.c
1 file changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/common/vty.c b/src/common/vty.c
index 36b0eaf..dd83a11 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -637,13 +637,9 @@
 {
 	struct gsm_bts *bts = vty->index;
 
-	if (bts->pcu.sock_path) {
-		/* FIXME: close the interface? */
-		talloc_free(bts->pcu.sock_path);
-	}
-	bts->pcu.sock_path = talloc_strdup(bts, argv[0]);
-	/* FIXME: re-open the interface? */
+	osmo_talloc_replace_string(bts, &bts->pcu.sock_path, argv[0]);
 
+	/* FIXME: re-open the interface? */
 	return CMD_SUCCESS;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20287
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic195cef2aafec55d37152045f7714335ded0a62b
Gerrit-Change-Number: 20287
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200930/ad72a748/attachment.htm>