Change in osmo-trx[master]: vty: add attributes to VTY commands indicating when they apply

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Sep 29 20:04:51 UTC 2020


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/20319 )


Change subject: vty: add attributes to VTY commands indicating when they apply
......................................................................

vty: add attributes to VTY commands indicating when they apply

Change-Id: I6dfdedc081eb8c3d53913f6fa38591920c8b3b43
Related: SYS#4937, OS#1601
---
M CommonLibs/trx_vty.c
1 file changed, 23 insertions(+), 19 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/19/20319/1

diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c
index 3fcf888..9d8aecf 100644
--- a/CommonLibs/trx_vty.c
+++ b/CommonLibs/trx_vty.c
@@ -97,9 +97,10 @@
 	1,
 };
 
-DEFUN(cfg_trx, cfg_trx_cmd,
-	"trx",
-	"Configure the TRX\n")
+DEFUN_ATTR(cfg_trx, cfg_trx_cmd,
+	   "trx",
+	   "Configure the TRX\n",
+	   CMD_ATTR_IMMEDIATE)
 {
 	struct trx_ctx *trx = trx_from_vty(vty);
 
@@ -415,12 +416,13 @@
 	INTV_STR_VAL(per-hour) \
 	INTV_STR_VAL(per-day)
 
-DEFUN(cfg_ctr_error_threshold, cfg_ctr_error_threshold_cmd,
-	"ctr-error-threshold " THRESHOLD_ARGS " <0-65535> " INTV_ARGS,
-	"Threshold rate for error counter\n"
-	THRESHOLD_STRS
-	"Value to set for threshold\n"
-	INTV_STRS)
+DEFUN_ATTR(cfg_ctr_error_threshold, cfg_ctr_error_threshold_cmd,
+	   "ctr-error-threshold " THRESHOLD_ARGS " <0-65535> " INTV_ARGS,
+	   "Threshold rate for error counter\n"
+	   THRESHOLD_STRS
+	   "Value to set for threshold\n"
+	   INTV_STRS,
+	   CMD_ATTR_IMMEDIATE)
 {
 	int rc;
 	struct ctr_threshold ctr;
@@ -446,12 +448,13 @@
 	return CMD_SUCCESS;
 }
 
-DEFUN(cfg_no_ctr_error_threshold, cfg_no_ctr_error_threshold_cmd,
-	"no ctr-error-threshold " THRESHOLD_ARGS " <0-65535> " INTV_ARGS,
-	NO_STR "Threshold rate for error counter\n"
-	THRESHOLD_STRS
-	"Value to set for threshold\n"
-	INTV_STRS)
+DEFUN_ATTR(cfg_no_ctr_error_threshold, cfg_no_ctr_error_threshold_cmd,
+	   "no ctr-error-threshold " THRESHOLD_ARGS " <0-65535> " INTV_ARGS,
+	   NO_STR "Threshold rate for error counter\n"
+	   THRESHOLD_STRS
+	   "Value to set for threshold\n"
+	   INTV_STRS,
+	   CMD_ATTR_IMMEDIATE)
 {
 	int rc;
 	struct ctr_threshold ctr;
@@ -480,10 +483,11 @@
 	return CMD_SUCCESS;
 }
 
-DEFUN(cfg_chan, cfg_chan_cmd,
-	"chan <0-100>",
-	"Select a channel to configure\n"
-	"Channel index\n")
+DEFUN_ATTR(cfg_chan, cfg_chan_cmd,
+	   "chan <0-100>",
+	   "Select a channel to configure\n"
+	   "Channel index\n",
+	   CMD_ATTR_IMMEDIATE)
 {
 	struct trx_ctx *trx = trx_from_vty(vty);
 	int idx = atoi(argv[0]);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20319
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6dfdedc081eb8c3d53913f6fa38591920c8b3b43
Gerrit-Change-Number: 20319
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200929/4adb721d/attachment.htm>


More information about the gerrit-log mailing list