Change in libosmocore[master]: gsm_12_21: add osmo_oml_nsvc_address_type for OML NM_ATT_OSMO_NS_LINK...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Sep 29 16:37:32 UTC 2020


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20289 )

Change subject: gsm_12_21: add osmo_oml_nsvc_address_type for OML NM_ATT_OSMO_NS_LINK_CFG
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/20289/1/include/osmocom/gsm/protocol/gsm_12_21.h 
File include/osmocom/gsm/protocol/gsm_12_21.h:

https://gerrit.osmocom.org/c/libosmocore/+/20289/1/include/osmocom/gsm/protocol/gsm_12_21.h@794 
PS1, Line 794: 0x00
> sure this should be 0x00 and not 0xff to make this compatible with the ip protocol/next header field […]
0x00 is just undefined or when the memory is zeroed.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20289
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9e279bb20940c66eea5196f281184cb4f8a5cc5f
Gerrit-Change-Number: 20289
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: roh <jsteiger at sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Sep 2020 16:37:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: roh <jsteiger at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200929/e49586f2/attachment.htm>


More information about the gerrit-log mailing list