This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20290 ) Change subject: generate_ma_for_ts: check num_cell_arfcns to guarantee no out-of-bounds access ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > I'm unsure if this is right or if it even can happen (because it doesn't make sense to have more than 64 trx per bts). > @fixeria: I stumpled into it while migrating your frequency hopping patch for osmo-bsc. I think it can happen, given that we do not limit the number of channels that can be configured via the VTY interface. https://gerrit.osmocom.org/c/osmo-bsc/+/20290/1/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20290/1/src/osmo-bsc/osmo_bsc_main.c@260 PS1, Line 260: num_cell_arfcns = sizeof(ts->hopping.ma_data); I think we should not silently truncate the list. Let's rather return an error and make sure that the caller would terminate the process with proper logging message? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2ee8e8b4ba5e16b955685ba42bd58dc2ea08720f Gerrit-Change-Number: 20290 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Comment-Date: Sun, 27 Sep 2020 17:55:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200927/b89d2c02/attachment.htm>