This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20272 )
Change subject: Introduce the new OML NM_ATT_OSMO_NS_LINK_CFG to configure IPv6 NSVC for PCU
......................................................................
Patch Set 2:
(5 comments)
This change is ready for review.
https://gerrit.osmocom.org/c/osmo-bts/+/20272/1/src/common/oml.c
File src/common/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/20272/1/src/common/oml.c@1291
PS1, Line 1291: IPPROTO_IPIP
> why not AF_INET / AF_INET6?
AF_INET6 wasn't the same on all architectures I've looked onto. But pespin disliked borrowing IPPROTO, so I've created our own for PCUIF and OML.
https://gerrit.osmocom.org/c/osmo-bts/+/20272/1/src/common/oml.c@1291
PS1, Line 1291: case IPPROTO_IPIP:
> Again, this kind of define being used here makes no sense to me, it's confusing. […]
Ack
https://gerrit.osmocom.org/c/osmo-bts/+/20272/1/src/common/oml.c@1292
PS1, Line 1292: /* we already checked for 10 bytes */
> No TLVP_LEN check here, as done in ipv6?
it's checked already for 10 bytes.
https://gerrit.osmocom.org/c/osmo-bts/+/20272/1/src/common/oml.c@1295
PS1, Line 1295: memcpy(&nsvc->remote.u.sin.sin_addr.s_addr, cur, sizeof(in_addr_t));
> memcopying into sin_addr and using sizeof(struct sin_addr) is what we usually use, and may be more p […]
I'm unsure if `struct sin_addr` is being padded or not. It shouldn't be of course. So in_addr_t should be the correct type of s_addr.
https://gerrit.osmocom.org/c/osmo-bts/+/20272/1/src/common/oml.c@1302
PS1, Line 1302: nsvc->remote.u.sas.ss_family = AF_INET6;
: nsvc->local.u.sas.ss_family = AF_INET;
> are we sure local shouldn't be AF_INET6?
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20272
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I310699fabbfec4255f0474f31717f215c1201eca
Gerrit-Change-Number: 20272
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 26 Sep 2020 22:58:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200926/47e2705c/attachment.htm>