Change in osmo-bsc[master]: generate_ma_for_ts: check num_cell_arfcns to guarantee no out-of-boun...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Sat Sep 26 21:55:08 UTC 2020


lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20290 )


Change subject: generate_ma_for_ts: check num_cell_arfcns to guarantee no out-of-bounds access
......................................................................

generate_ma_for_ts: check num_cell_arfcns to guarantee no out-of-bounds access

Change-Id: I2ee8e8b4ba5e16b955685ba42bd58dc2ea08720f
---
M src/osmo-bsc/osmo_bsc_main.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/90/20290/1

diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index 20bd620..b822a05 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -256,6 +256,9 @@
 			num_cell_arfcns++;
 	}
 
+	if (num_cell_arfcns > sizeof(ts->hopping.ma_data) * 8)
+		num_cell_arfcns = sizeof(ts->hopping.ma_data);
+
 	/* pad it to octet-aligned number of bits */
 	ts->hopping.ma_len = OSMO_BYTES_FOR_BITS(num_cell_arfcns);
 	ma->cur_bit = (ts->hopping.ma_len * 8) - 1;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20290
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2ee8e8b4ba5e16b955685ba42bd58dc2ea08720f
Gerrit-Change-Number: 20290
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200926/8135b096/attachment.htm>


More information about the gerrit-log mailing list