Change in osmo-bsc[master]: oml: encode IPv6 NSVC using the new OML attribute NM_ATT_OSMO_NS_LINK...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Sat Sep 26 17:13:42 UTC 2020


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20234 )

Change subject: oml: encode IPv6 NSVC using the new OML attribute NM_ATT_OSMO_NS_LINK_CFG
......................................................................


Patch Set 3:

(2 comments)

I've dropped the PCU socket part. it shouldn't be in here and will be in a second patch

https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bsc_vty.c@3043 
PS3, Line 3043: 	ret = osmo_sockaddr_str_from_str2(&remote, argv[1]);
> You could probably simply use osmo_ip_str_type() and feet address_family to the switch statement bel […]
Yes it would be possible. I would leave it as it is because it's just a different api which saves a little bit stack here.


https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bts_ipaccess_nanobts.c 
File src/osmo-bsc/bts_ipaccess_nanobts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bts_ipaccess_nanobts.c@232 
PS3, Line 232: 			LOGP(DLINP, LOGL_ERROR, "BTS %d does not support IPv6 but require it!\n", bts->nr);
> this err string is confusing. Better "but an IPv6 address was configured".
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20234
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6529876a3c1116a79dd624312243d8ae48a41fe2
Gerrit-Change-Number: 20234
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 26 Sep 2020 17:13:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200926/7167ff02/attachment.htm>


More information about the gerrit-log mailing list