This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20271 ) Change subject: Use the new NS2 lib ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/20271/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/20271/1/src/gprs_bssgp_pcu.cpp@630 PS1, Line 630: struct gprs_ns2_inst *nsi = (struct gprs_ns2_inst *) ctx; : struct osmo_gprs_ns2_prim nsp = {}; : nsp.nsei = msgb_nsei(msg); : nsp.bvci = msgb_bvci(msg); : osmo_prim_init(&nsp.oph, SAP_NS, PRIM_NS_UNIT_DATA, : PRIM_OP_REQUEST, msg); : return gprs_ns2_recv_prim(nsi, &nsp.oph); > Any reason to go for a primitive on the stack instaed? I used the same way as it was used in bssgp (osmo_bssgp_prim) and in the lapm (osmo_dlsap_prim). -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib389925cf5c9f18951af6242c31ea70476218e9a Gerrit-Change-Number: 20271 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sat, 26 Sep 2020 17:09:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200926/3f3d91a9/attachment.htm>