This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20234 ) Change subject: oml: encode IPv6 NSVC using the new OML attribute NM_ATT_OSMO_NS_LINK_CFG ...................................................................... Patch Set 3: (8 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bsc_vty.c@3043 PS3, Line 3043: ret = osmo_sockaddr_str_from_str2(&remote, argv[1]); You could probably simply use osmo_ip_str_type() and feet address_family to the switch statement below. https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bts_ipaccess_nanobts.c File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bts_ipaccess_nanobts.c@232 PS3, Line 232: LOGP(DLINP, LOGL_ERROR, "BTS %d does not support IPv6 but require it!\n", bts->nr); this err string is confusing. Better "but an IPv6 address was configured". https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c@206 PS3, Line 206: if (bts->gprs.nsvc->remote.u.sa.sa_family == AF_INET6) { switch? https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c@208 PS3, Line 208: osmo_store16be(IPPROTO_IPV6, &buf[0]); Please let's use our own define here, not this define which was nothing to do. That's for IPoverIP. https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c@212 PS3, Line 212: memcpy(&buf[4], &bts->gprs.nsvc[0].remote.u.sin6.sin6_port, sizeof(uint16_t)); Really? memcpy for a uint16_t? https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c@218 PS3, Line 218: memcpy(&buf[0], &bts->gprs.nsvc[0].remote.u.sin.sin_port, sizeof(uint16_t)); Same https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/pcu_sock.c File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/pcu_sock.c@199 PS3, Line 199: LOGP(DPCU, LOGL_ERROR, "Can not encode IPv6 NSVC!"); didn't fixeria already add support for it? https://gerrit.osmocom.org/c/osmo-bsc/+/20234/3/src/osmo-bsc/pcu_sock.c@205 PS3, Line 205: info_ind->nsvci[i] = nsvc->nsvci; You should have 2 iter variable shere, otherwise if you "continue;" above, you end up with holes in the struct. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6529876a3c1116a79dd624312243d8ae48a41fe2 Gerrit-Change-Number: 20234 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 25 Sep 2020 11:02:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200925/fc74b601/attachment.htm>