This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20268 ) Change subject: ns2: ns2_recv_vc: remove unused parameter nsi ...................................................................... ns2: ns2_recv_vc: remove unused parameter nsi Change-Id: I0dbc079e83d37de01a4260442363ed5fdcd51d28 --- M src/gb/gprs_ns2.c M src/gb/gprs_ns2_frgre.c M src/gb/gprs_ns2_internal.h M src/gb/gprs_ns2_udp.c 4 files changed, 8 insertions(+), 11 deletions(-) Approvals: laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c index 835c22a..05d4972 100644 --- a/src/gb/gprs_ns2.c +++ b/src/gb/gprs_ns2.c @@ -844,12 +844,10 @@ /*! Bottom-side entry-point for received NS PDU from the driver/bind - * \param[in] nsi NS instance * \param[in] nsvc NS-VC for which the message was received * \param msg the received message. Ownership is trasnferred, caller must not free it! * \return 0 on success; negative on error */ -int ns2_recv_vc(struct gprs_ns2_inst *nsi, - struct gprs_ns2_vc *nsvc, +int ns2_recv_vc(struct gprs_ns2_vc *nsvc, struct msgb *msg) { struct gprs_ns_hdr *nsh = (struct gprs_ns_hdr *) msg->l2h; diff --git a/src/gb/gprs_ns2_frgre.c b/src/gb/gprs_ns2_frgre.c index 715c41a..0903e46 100644 --- a/src/gb/gprs_ns2_frgre.c +++ b/src/gb/gprs_ns2_frgre.c @@ -446,7 +446,7 @@ rc = ns2_create_vc(bind, msg, "newconnection", &reject, &nsvc); switch (rc) { case GPRS_NS2_CS_FOUND: - rc = ns2_recv_vc(bind->nsi, nsvc, msg); + rc = ns2_recv_vc(nsvc, msg); break; case GPRS_NS2_CS_ERROR: case GPRS_NS2_CS_SKIPPED: @@ -459,12 +459,12 @@ case GPRS_NS2_CS_CREATED: frgre_alloc_vc(bind, nsvc, &saddr, dlci); gprs_ns2_vc_fsm_start(nsvc); - rc = ns2_recv_vc(bind->nsi, nsvc, msg); + rc = ns2_recv_vc(nsvc, msg); break; } } else { /* VC found */ - rc = ns2_recv_vc(bind->nsi, nsvc, msg); + rc = ns2_recv_vc(nsvc, msg); } out: msgb_free(msg); diff --git a/src/gb/gprs_ns2_internal.h b/src/gb/gprs_ns2_internal.h index 708eb59..15b0bc5 100644 --- a/src/gb/gprs_ns2_internal.h +++ b/src/gb/gprs_ns2_internal.h @@ -203,8 +203,7 @@ struct msgb **reject, struct gprs_ns2_vc **success); -int ns2_recv_vc(struct gprs_ns2_inst *nsi, - struct gprs_ns2_vc *nsvc, +int ns2_recv_vc(struct gprs_ns2_vc *nsvc, struct msgb *msg); struct gprs_ns2_vc *ns2_vc_alloc(struct gprs_ns2_vc_bind *bind, diff --git a/src/gb/gprs_ns2_udp.c b/src/gb/gprs_ns2_udp.c index 9994a72..2f55f2a 100644 --- a/src/gb/gprs_ns2_udp.c +++ b/src/gb/gprs_ns2_udp.c @@ -195,7 +195,7 @@ rc = ns2_create_vc(bind, msg, "newconnection", &reject, &nsvc); switch (rc) { case GPRS_NS2_CS_FOUND: - rc = ns2_recv_vc(bind->nsi, nsvc, msg); + rc = ns2_recv_vc(nsvc, msg); break; case GPRS_NS2_CS_ERROR: case GPRS_NS2_CS_SKIPPED: @@ -208,12 +208,12 @@ case GPRS_NS2_CS_CREATED: ns2_driver_alloc_vc(bind, nsvc, &saddr); gprs_ns2_vc_fsm_start(nsvc); - rc = ns2_recv_vc(bind->nsi, nsvc, msg); + rc = ns2_recv_vc(nsvc, msg); break; } } else { /* VC found */ - rc = ns2_recv_vc(bind->nsi, nsvc, msg); + rc = ns2_recv_vc(nsvc, msg); } msgb_free(msg); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0dbc079e83d37de01a4260442363ed5fdcd51d28 Gerrit-Change-Number: 20268 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200925/31da4fcf/attachment.htm>