Change in osmo-mgw[master]: mgcp_vty: deprecate bind early command

[dexter]

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/20248 )

Change subject: mgcp_vty: deprecate bind early command
......................................................................

mgcp_vty: deprecate bind early command

The VTY command "bind early" is deprecated but it prints an error
message and the DEFUN is not set to DEFUN_DEPRECATED.

Change-Id: I594a87d2f63826a9d7b4f6a380586b08b3b79518
---
M src/libosmo-mgcp/mgcp_vty.c
1 file changed, 6 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/libosmo-mgcp/mgcp_vty.c b/src/libosmo-mgcp/mgcp_vty.c
index cc7c5b8..440452f 100644
--- a/src/libosmo-mgcp/mgcp_vty.c
+++ b/src/libosmo-mgcp/mgcp_vty.c
@@ -442,14 +442,13 @@
 	return CMD_SUCCESS;
 }
 
-DEFUN(cfg_mgcp_bind_early,
-      cfg_mgcp_bind_early_cmd,
-      "bind early (0|1)",
-      BIND_STR
-      "Bind local ports on start up\n" "Bind on demand\n" "Bind on startup\n")
+DEFUN_DEPRECATED(cfg_mgcp_bind_early,
+		 cfg_mgcp_bind_early_cmd,
+		 "bind early (0|1)",
+		 BIND_STR
+		 "Bind local ports on start up\n" "Bind on demand\n" "Bind on startup\n")
 {
-	vty_out(vty, "bind early is deprecated, remove it from the config.\n");
-	return CMD_WARNING;
+	return CMD_SUCCESS;
 }
 
 #define RTP_STR "RTP configuration\n"

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/20248
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I594a87d2f63826a9d7b4f6a380586b08b3b79518
Gerrit-Change-Number: 20248
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200924/5a878d1c/attachment.htm>